Hershey's pot of gold make a good xmas gift? is it considered cheap?

If that fits your budget, and the person you are giving it to likes chocolates, then it's a great gift. in fact, it's traditional. Kids have been gving moms 'pot of gold' chocolates for generations.